-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Scylla Server in Rust #171
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Peyton-McKee
previously approved these changes
Aug 29, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
YIPPPEEEE
RChandler234
requested changes
Sep 16, 2024
* basic proof of concept * misc improvements and cleanup of cursory processing * implement reids review suggestions * try and fix clippy * and again fix clippy * make data query optional to reset calypso to default if calypso receives a short or emtpy protobuf command_data, it will fill the extra values with the default value specified in the YAML. so we should allow the client to specify blank which could end up meaning a "Reset to Default" button. * clippy is trolling me * fixup error handling for plaintext error message * implement reid fixes * remove not prod error
jr1221
force-pushed
the
feature/scylla-rust-server
branch
from
September 16, 2024 23:34
b5e06d5
to
f0956c2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a whole lot.
The new folder scylla-server-rust contains a complete scylla implementation in rust. Functional differences to the JS one:
Latency
key to see latency to serverruns/new
endpoint for creating a new runStuff outside of the
scylla-server-rust
scope:argos-client
andargos-scylla
seperately